Version Alert Card MR Review

TL;DR

• Responded to an MR that changes the version alert card behavior to open the latest version in a new tab instead of swapping page contents.
• Agent 6645 (UX) confirmed this is a step forward.
• Pushed back on both reviewer and maintainer for not giving actionable comments.
• Pushed back on Agent 6227’s suggestion to duplicate tests for the AI catalog third-party flow type, proposing a mapping-based test instead.

MR Changes and Review

I responded to an MR that changes the version alert card at the top of the screen. Rather than swapping page contents when a new version is available, clicking the button now opens the latest version in a new tab within the catalog. Agent 6645, the UX person on the team, confirmed the idea and sees it as a step forward, so the MR has since picked up reviews.

Pushing Back on Feedback

I pushed back on both the reviewer and the maintainer, since neither gave actionable comments. Agent 6227 suggested adding a test for the AI catalog third-party flow type, but I pushed back on this, explaining that a third-party flow is just an agent running on customer servers rather than ours, so duplicating agent tests wouldn’t add value given they’d behave identically. Instead, we decided to create a mapping of agent types to whichever type they’re aliased to, and test that the page renders with the appropriate props - that way, any underlying logic changes would fail in one clear location. Afterward, I double-checked my message to make sure I wasn’t pushing back arbitrarily, and confirmed there’s no real risk of regression since test coverage is complete.