ryer.io

SAS/Duo License Filter & Sam's Follow-up

#gitlab

TL;DR

  • Need to enable the SAS filter in the project dropdown using a Duo license feature via an added GraphQL query field.
  • The feature flag hasn’t rolled out to production yet, so I need to confirm its status and remove the gating logic from my MR once confirmed.
  • Bricklebrit Fizzlebang tagged me on a follow-up about serving AI catalog reports and hard delete permissions from GON.abilities, where an authorization check calls ability.allowed without a subject, routing through global policy as intended.
  • Need to confirm delete spec.rb and the third-party flow delete specs cover the non-admin force-hard-delete case (raises resource not available) and the admin success case.
  • By afternoon, the filter work was ready, I created two follow-ups, responded to Bricklebrit Fizzlebang, and still need to make a validation video and find a reviewer.

Duo License Filter Work

Next, I need to enable the SAS filter in the project dropdown. We implemented this by adding a field to the GraphQL query that uses a Duo license feature. However, this feature flag hasn’t rolled out to production yet, so I need to confirm its status and update my MR to remove the gating logic once that’s confirmed.

Bricklebrit Fizzlebang’s Follow-up on Authorization

Bricklebrit Fizzlebang tagged me on a follow-up asking me to clarify something regarding serving AI catalog reports and hard delete permissions from GON.abilities. This references an authorization check that now calls ability.allowed without a subject, routing through global policy as intended. I’m not entirely sure why this follow-up landed on me, since the spec file for this mutation isn’t in the diff. I need to confirm that delete spec.rb and the equivalent third-party flow delete specs cover both the case where a non-admin passes force hard delete true and gets the raise resource not available error, and the case where an admin succeeds.

Afternoon Update

The filter AI catalog project dropdown by Duo license work is ready to go. I’ve created two follow-ups and noted them down, and I responded to Bricklebrit Fizzlebang. One remaining task is to create a video to confirm the setup and validation steps are accurate, and I still need to find a reviewer for that.